Projects
Eulaceura:Factory
qt5-qtdeclarative
_service:obs_scm:0020-qv4function-Fix-crash-due...
Sign Up
Log In
Username
Password
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File _service:obs_scm:0020-qv4function-Fix-crash-due-to-reference-being-invalid.patch of Package qt5-qtdeclarative
From adad56c92c633248f0fe467f8e0c32dc461f6716 Mon Sep 17 00:00:00 2001 From: Maximilian Goldstein <max.goldstein@qt.io> Date: Wed, 9 Jun 2021 15:02:45 +0200 Subject: [PATCH 20/26] qv4function: Fix crash due to reference being invalidated Function::updateInternalClass creates a reference to a QStringList that is appended to before being used. This is unsafe and can leads to a segfault if the append() causes a reallocation. Fixes: QTBUG-94360 Pick-to: 5.15 6.1 6.2 Change-Id: Iac49e8d816cf440ca2b70e133c88314eb8df6b91 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Andrei Golubev <andrei.golubev@qt.io> (cherry picked from commit 7fa28f98824a94396106eadfc028b329985a0cfc) --- src/qml/jsruntime/qv4function.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qml/jsruntime/qv4function.cpp b/src/qml/jsruntime/qv4function.cpp index aeb4835c40..9082628a1a 100644 --- a/src/qml/jsruntime/qv4function.cpp +++ b/src/qml/jsruntime/qv4function.cpp @@ -136,7 +136,7 @@ void Function::updateInternalClass(ExecutionEngine *engine, const QList<QByteArr if (duplicate == -1) { parameterNames.append(QString::fromUtf8(param)); } else { - const QString &dup = parameterNames[duplicate]; + const QString dup = parameterNames[duplicate]; parameterNames.append(dup); parameterNames[duplicate] = QString(0xfffe) + QString::number(duplicate) + dup; -- 2.40.1
Locations
Projects
Search
Status Monitor
Help
Open Build Service
OBS Manuals
API Documentation
OBS Portal
Reporting a Bug
Contact
Mailing List
Forums
Chat (IRC)
Twitter
Open Build Service (OBS)
is an
openSUSE project
.
浙ICP备2022010568号-2