File _service:tar_scm:fix-bubble_contents_wrapper.h-... of Package lld-15

File _service:tar_scm:fix-bubble_contents_wrapper.h-static-assert.patch of Package lld-15 (Revision 04248f82f46d58b8c97cb8c08f274f0b)

Currently displaying revision 04248f82f46d58b8c97cb8c08f274f0b , Show latest

Fix compile error by removing a trivial static_assert (the code is refactored in 123):

```
In file included from ../../chrome/browser/ui/commerce/commerce_ui_tab_helper.cc:28:                                                                                      
In file included from ../../chrome/browser/ui/views/side_panel/side_panel_web_ui_view.h:12:                                                                               
../../chrome/browser/ui/views/bubble/bubble_contents_wrapper.h:153:9: error: static assertion expression is not an integral constant expression                           
        views_metrics::IsValidWebUINameVariant("." + T::GetWebUIName()));                                                                                                 
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                                                   
/usr/bin/../lib/gcc/riscv64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:1070:34: note: in instantiation of member function 'BubbleContentsWrapperT<ShoppingInsightsSidePanelUI>::BubbleContentsWrapperT' requested here
    { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }                                                                                                  
                                 ^                                                                                                                                        
../../chrome/browser/ui/commerce/commerce_ui_tab_helper.cc:458:16: note: in instantiation of function template specialization 'std::make_unique<BubbleContentsWrapperT<ShoppingInsightsSidePanelUI>, GURL, Profile *, int, bool, bool>' requested here
          std::make_unique<BubbleContentsWrapperT<ShoppingInsightsSidePanelUI>>(                                                                                          
               ^                                                                                                                                                          
/usr/bin/../lib/gcc/riscv64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:97:14: note: construction of subobject of member '_M_local_buf' of union with active member '_M_allocated_capacity' is not allowed in a constant expression
    { return ::new((void*)__location) _Tp(std::forward<_Args>(__args)...); }                                                                                              
             ^                                                                                                                                                            
/usr/bin/../lib/gcc/riscv64-linux-gnu/13/../../../../include/c++/13/bits/char_traits.h:365:4: note: in call to 'construct_at(&ShoppingInsightsSidePanelUI::GetWebUIName().._M_local_buf[0], char())'
          std::construct_at(__builtin_addressof(__c1), __c2);                                                                                                             
          ^                                                                                                                                                               
/usr/bin/../lib/gcc/riscv64-linux-gnu/13/../../../../include/c++/13/bits/basic_string.h:257:2: note: in call to 'assign(ShoppingInsightsSidePanelUI::GetWebUIName().._M_local_buf[0], char())'
        traits_type::assign(_M_data()[__n], _CharT());                                                                                                                    
        ^                                                                                                                                                                 
/usr/bin/../lib/gcc/riscv64-linux-gnu/13/../../../../include/c++/13/bits/basic_string.h:686:8: note: in call to '&ShoppingInsightsSidePanelUI::GetWebUIName()->_M_set_length(0)'
        __str._M_set_length(0);                                                                                                                                           
              ^                                                                                                                                                           
/usr/bin/../lib/gcc/riscv64-linux-gnu/13/../../../../include/c++/13/bits/basic_string.h:3664:14: note: in call to 'basic_string(ShoppingInsightsSidePanelUI::GetWebUIName())'
    { return std::move(__rhs.insert(0, __lhs)); }                                                                                                                         
             ^                                                                                                                                                            
../../chrome/browser/ui/views/bubble/bubble_contents_wrapper.h:153:52: note: in call to 'operator+(&"."[0], ShoppingInsightsSidePanelUI::GetWebUIName())'                 
        views_metrics::IsValidWebUINameVariant("." + T::GetWebUIName()));                                                                                                 
                                                   ^
```
--- a/chrome/browser/ui/views/bubble/bubble_contents_wrapper.h
+++ b/chrome/browser/ui/views/bubble/bubble_contents_wrapper.h
@@ -149,8 +149,6 @@
                               esc_closes_ui,
                               T::GetWebUIName()),
         webui_url_(webui_url) {
-    static_assert(
-        views_metrics::IsValidWebUINameVariant("." + T::GetWebUIName()));
   }
 
   void ReloadWebContents() override {